AllenNeuralDynamics / AllenNeuralDynamics/ficus

Remove db-structure-related contents of settings.json

オープン
#38 コメント 0 件 リアクション 0 件 担当者 1 名 @jessy-liao が担当を希望しています GitHub で見る
主要言語
Python
スター
1
フォーク
0
PR マージ指標
30日以内にマージされた PR はありません

説明

Ficus **settings.json** file, currently required for each PC that wants to communicate with ficus, require a `scope` field.

Here's an [example settings.json](https://github.com/AllenNeuralDynamics/prototome-instrument/blob/dev/examples/ficus_setup.json).

The contents of the `scope` field are basically validating the internal structure of the connected database. If that's indeed the case, let's not do this at this level and instead do it inside of the ficus client library (probably with a pydantic model). Doing it at this level violates separation of concerns where each computer that wants to interact with the database needs to know something about its structure in order to interact with it rather than delegating that work to the ficus client library. It also makes the file harder to maintain since individual fields will need to change everywhere if the folder structure ever changes.

That's all to say, let's remove this `scope` field from **settings.json** if possible.

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。