AllenNeuralDynamics / AllenNeuralDynamics/ficus

Remove db-structure-related contents of settings.json

Abierto
#38 0 comentarios 0 reacciones 1 asignado Reclamado por @jessy-liao Ver en GitHub
Lenguaje dominante
Python
Estrellas
1
Forks
0
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Ficus **settings.json** file, currently required for each PC that wants to communicate with ficus, require a `scope` field.

Here's an [example settings.json](https://github.com/AllenNeuralDynamics/prototome-instrument/blob/dev/examples/ficus_setup.json).

The contents of the `scope` field are basically validating the internal structure of the connected database. If that's indeed the case, let's not do this at this level and instead do it inside of the ficus client library (probably with a pydantic model). Doing it at this level violates separation of concerns where each computer that wants to interact with the database needs to know something about its structure in order to interact with it rather than delegating that work to the ficus client library. It also makes the file harder to maintain since individual fields will need to change everywhere if the folder structure ever changes.

That's all to say, let's remove this `scope` field from **settings.json** if possible.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.