AllenNeuralDynamics / AllenNeuralDynamics/biodata-schema

[v3] Separate device configurations from device properties

Aperta
#33 0 commenti 0 reazioni 1 assegnatario Rivendicata da @dbirman Vedi su GitHub
Lingua principale
Python
Stelle
0
Fork
0
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Right now the subclasses of `Device` mix the static properties of devices with configurable settings. We should clearly separate configurations going forward. I see two options:

1. All configuration properties go in `Acquisition`
2. We add `Instrument.configs` which accepts the same discriminated list allowed in acquisition

I think that 1 is cleaner ultimately and will make the metadata more maintainable. Fortunately this is an easy thing to implement in the v2->v3 upgrader since it should just be copying values from the existing device classes into their corresponding configuration classes, although if it crosses classes that will be complex to implement.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.