AllenNeuralDynamics / AllenNeuralDynamics/biodata-schema

[v3] Separate device configurations from device properties

Offen
#33 0 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @dbirman Auf GitHub ansehen
Vorherrschende Sprache
Python
Sterne
0
Forks
0
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Right now the subclasses of `Device` mix the static properties of devices with configurable settings. We should clearly separate configurations going forward. I see two options:

1. All configuration properties go in `Acquisition`
2. We add `Instrument.configs` which accepts the same discriminated list allowed in acquisition

I think that 1 is cleaner ultimately and will make the metadata more maintainable. Fortunately this is an easy thing to implement in the v2->v3 upgrader since it should just be copying values from the existing device classes into their corresponding configuration classes, although if it crosses classes that will be complex to implement.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.