AllenNeuralDynamics / AllenNeuralDynamics/biodata-schema

[v3] Separate device configurations from device properties

Ouverte
#33 0 commentaires 0 réactions 1 personne assignée Réclamée par @dbirman Voir sur GitHub
Langage dominant
Python
Étoiles
0
Forks
0
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Right now the subclasses of `Device` mix the static properties of devices with configurable settings. We should clearly separate configurations going forward. I see two options:

1. All configuration properties go in `Acquisition`
2. We add `Instrument.configs` which accepts the same discriminated list allowed in acquisition

I think that 1 is cleaner ultimately and will make the metadata more maintainable. Fortunately this is an easy thing to implement in the v2->v3 upgrader since it should just be copying values from the existing device classes into their corresponding configuration classes, although if it crosses classes that will be complex to implement.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.