AllenNeuralDynamics / AllenNeuralDynamics/biodata-schema

[v3] Separate device configurations from device properties

Abierto
#33 0 comentarios 0 reacciones 1 asignado Reclamado por @dbirman Ver en GitHub
Lenguaje dominante
Python
Estrellas
0
Forks
0
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Right now the subclasses of `Device` mix the static properties of devices with configurable settings. We should clearly separate configurations going forward. I see two options:

1. All configuration properties go in `Acquisition`
2. We add `Instrument.configs` which accepts the same discriminated list allowed in acquisition

I think that 1 is cleaner ultimately and will make the metadata more maintainable. Fortunately this is an easy thing to implement in the v2->v3 upgrader since it should just be copying values from the existing device classes into their corresponding configuration classes, although if it crosses classes that will be complex to implement.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.