AllenNeuralDynamics / AllenNeuralDynamics/aind-ophys-roicat-session-matching

Unreliable plane index definition

Aperta
#9 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Jupyter Notebook
Stelle
0
Fork
0
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

In path_io.py, plane_index is defined by os.listdir(session_dir) in load_session_planes (https://github.com/AllenNeuralDynamics/aind-ophys-roicat-session-matching/blob/main/code/path_io.py#L51). But this requires assumption that the plane indices remain the same across sessions. This was violated when new types of files are added (e.g., 9697b3bc-5085-4aac-b475-7235b9cf80fc).

Instead, it would be better to list plane ids across sessions first, dub indices to them (based on numbering at the end, or by sorting the plane names), and then run the rest of the pipeline.

It failed when running 823831 due to added files such as "-46.0.tif"

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.