AllenNeuralDynamics / AllenNeuralDynamics/aind-ophys-roicat-session-matching

Unreliable plane index definition

Open
#9 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

In path_io.py, plane_index is defined by os.listdir(session_dir) in load_session_planes (https://github.com/AllenNeuralDynamics/aind-ophys-roicat-session-matching/blob/main/code/path_io.py#L51). But this requires assumption that the plane indices remain the same across sessions. This was violated when new types of files are added (e.g., 9697b3bc-5085-4aac-b475-7235b9cf80fc).

Instead, it would be better to list plane ids across sessions first, dub indices to them (based on numbering at the end, or by sorting the plane names), and then run the rest of the pipeline.

It failed when running 823831 due to added files such as "-46.0.tif"

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.