AllenCell / AllenCell/vole-core

Don't load disabled channels

オープン
#158 コメント 0 件 リアクション 0 件 担当者 1 名 @frasercl が担当を希望しています GitHub で見る
主要言語
TypeScript
スター
106
フォーク
11
平均マージ
3日 51分
マージ済み PR(30日)
12

説明

## Use Case

Currently, we always load all channels any time we need new volume data, despite the fact that lots of use cases keep most channels of a volume disabled. (e.g. viewing the Variance dataset in CFE, whose segmentation and contour channels - a majority of total channels - are disabled by default.)

## Solution

We have a way to tell loaders which channels to load and a place to trigger new loads if we need new data. All we need to do is use them for channels as well!

As a bonus optimization, if the only change in required data is channels going from disabled to enabled, we should only load those channels, since we won't want any more data in any other channel. (This could get subtle with subregions - e.g. if enabled channels change _and the subregion also shrinks_, but the shrinkage won't result in a change of scale level per #157, load only the newly-enabled channels _at the old subregion_ to avoid dimension mismatches between old and new channels.)

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。