AllenCell / AllenCell/vole-core

Don't load disabled channels

Ouverte
#158 0 commentaires 0 réactions 1 personne assignée Réclamée par @frasercl Voir sur GitHub
Langage dominant
TypeScript
Étoiles
106
Forks
11
Merge moyen
3 j 51 min
PR mergées (30 j)
12

Description

## Use Case

Currently, we always load all channels any time we need new volume data, despite the fact that lots of use cases keep most channels of a volume disabled. (e.g. viewing the Variance dataset in CFE, whose segmentation and contour channels - a majority of total channels - are disabled by default.)

## Solution

We have a way to tell loaders which channels to load and a place to trigger new loads if we need new data. All we need to do is use them for channels as well!

As a bonus optimization, if the only change in required data is channels going from disabled to enabled, we should only load those channels, since we won't want any more data in any other channel. (This could get subtle with subregions - e.g. if enabled channels change _and the subregion also shrinks_, but the shrinkage won't result in a change of scale level per #157, load only the newly-enabled channels _at the old subregion_ to avoid dimension mismatches between old and new channels.)

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.