AllenCell / AllenCell/vole-core

Don't load disabled channels

Aperta
#158 0 commenti 0 reazioni 1 assegnatario Rivendicata da @frasercl Vedi su GitHub
Lingua principale
TypeScript
Stelle
106
Fork
11
Merge medio
3g 51m
PR unite (30g)
12

Descrizione

## Use Case

Currently, we always load all channels any time we need new volume data, despite the fact that lots of use cases keep most channels of a volume disabled. (e.g. viewing the Variance dataset in CFE, whose segmentation and contour channels - a majority of total channels - are disabled by default.)

## Solution

We have a way to tell loaders which channels to load and a place to trigger new loads if we need new data. All we need to do is use them for channels as well!

As a bonus optimization, if the only change in required data is channels going from disabled to enabled, we should only load those channels, since we won't want any more data in any other channel. (This could get subtle with subregions - e.g. if enabled channels change _and the subregion also shrinks_, but the shrinkage won't result in a change of scale level per #157, load only the newly-enabled channels _at the old subregion_ to avoid dimension mismatches between old and new channels.)

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.