AllenCell / AllenCell/vole-core

Don't load disabled channels

Offen
#158 0 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @frasercl Auf GitHub ansehen
Vorherrschende Sprache
TypeScript
Sterne
106
Forks
11
Ø Merge
3 T. 51 Min.
Gemergte PRs (30 T.)
12

Beschreibung

## Use Case

Currently, we always load all channels any time we need new volume data, despite the fact that lots of use cases keep most channels of a volume disabled. (e.g. viewing the Variance dataset in CFE, whose segmentation and contour channels - a majority of total channels - are disabled by default.)

## Solution

We have a way to tell loaders which channels to load and a place to trigger new loads if we need new data. All we need to do is use them for channels as well!

As a bonus optimization, if the only change in required data is channels going from disabled to enabled, we should only load those channels, since we won't want any more data in any other channel. (This could get subtle with subregions - e.g. if enabled channels change _and the subregion also shrinks_, but the shrinkage won't result in a change of scale level per #157, load only the newly-enabled channels _at the old subregion_ to avoid dimension mismatches between old and new channels.)

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.