AllenCell / AllenCell/agave

ROI clipping doesn't clip everything

未关闭
#51 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
C++
星标
62
派生
9
平均合并
1 天 2 小时
30 天内合并 PR
1

描述

## Description

When a ROI is slicing through the volume, normal vectors are still being computed as if the volume was whole. As a result, interiors of solid structures seem hollow when viewed as cross section. Also, scattered rays keep sampling the volume data that was clipped out.

## Expected Behavior

clipping the volume should truly remove that data from all sampling.

## Notes

per-channel clipping and truly zeroing out the gpu volume data would do the trick, instead of using the AABB only for the first ray-box hit. Also, testing the AABB on every sample would work as well (but slower?)

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。