AllenCell / AllenCell/agave

ROI clipping doesn't clip everything

Aperta
#51 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
C++
Stelle
62
Fork
9
Merge medio
1g 2h
PR unite (30g)
1

Descrizione

## Description

When a ROI is slicing through the volume, normal vectors are still being computed as if the volume was whole. As a result, interiors of solid structures seem hollow when viewed as cross section. Also, scattered rays keep sampling the volume data that was clipped out.

## Expected Behavior

clipping the volume should truly remove that data from all sampling.

## Notes

per-channel clipping and truly zeroing out the gpu volume data would do the trick, instead of using the AABB only for the first ray-box hit. Also, testing the AABB on every sample would work as well (but slower?)

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.