Akegarasu / Akegarasu/lora-scripts

Suggestions - Regarding the default parameters of the WD Tagger

Aperta
#643 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
enhancement
Lingua principale
Python
Stelle
6.1k
Fork
699
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I personally believe that two default parameters would benefit from adjustment, please consider it:

* **`escape_tag` :** Currently, this is enabled by default. **It would be better to set it to disabled by default.** Escaping parentheses during the tagging phase is unnecessary because the training process handles escaping automatically. If escaping is done during tagging, the entire process effectively escapes twice (as can be observed in the LoRA metadata).

* **`batch_output_action_on_conflict`:** Currently, this defaults to `copy`. This overwrites any existing tags with the inference results, and it has screwed my manually created tags twice (though, objectively, this was my mistake). **It would likely be better to default to `ignore`**, preserving existing tags, and allow users to manually select the `copy` mode when they intentionally want to overwrite them.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.