Akegarasu / Akegarasu/lora-scripts

Suggestions - Regarding the default parameters of the WD Tagger

Abierto
#643 0 comentarios 0 reacciones 0 asignados Ver en GitHub
enhancement
Lenguaje dominante
Python
Estrellas
6.1k
Forks
699
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

I personally believe that two default parameters would benefit from adjustment, please consider it:

* **`escape_tag` :** Currently, this is enabled by default. **It would be better to set it to disabled by default.** Escaping parentheses during the tagging phase is unnecessary because the training process handles escaping automatically. If escaping is done during tagging, the entire process effectively escapes twice (as can be observed in the LoRA metadata).

* **`batch_output_action_on_conflict`:** Currently, this defaults to `copy`. This overwrites any existing tags with the inference results, and it has screwed my manually created tags twice (though, objectively, this was my mistake). **It would likely be better to default to `ignore`**, preserving existing tags, and allow users to manually select the `copy` mode when they intentionally want to overwrite them.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.