Akegarasu / Akegarasu/lora-scripts

Suggestions - Regarding the default parameters of the WD Tagger

Ouverte
#643 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
enhancement
Langage dominant
Python
Étoiles
6.1k
Forks
699
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

I personally believe that two default parameters would benefit from adjustment, please consider it:

* **`escape_tag` :** Currently, this is enabled by default. **It would be better to set it to disabled by default.** Escaping parentheses during the tagging phase is unnecessary because the training process handles escaping automatically. If escaping is done during tagging, the entire process effectively escapes twice (as can be observed in the LoRA metadata).

* **`batch_output_action_on_conflict`:** Currently, this defaults to `copy`. This overwrites any existing tags with the inference results, and it has screwed my manually created tags twice (though, objectively, this was my mistake). **It would likely be better to default to `ignore`**, preserving existing tags, and allow users to manually select the `copy` mode when they intentionally want to overwrite them.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.