Akegarasu / Akegarasu/lora-scripts

Suggestions - Regarding the default parameters of the WD Tagger

Open
#643 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
6.1k
Forks
699
PR merge metrics
No merged PRs in 30d

Description

I personally believe that two default parameters would benefit from adjustment, please consider it:

* **`escape_tag` :** Currently, this is enabled by default. **It would be better to set it to disabled by default.** Escaping parentheses during the tagging phase is unnecessary because the training process handles escaping automatically. If escaping is done during tagging, the entire process effectively escapes twice (as can be observed in the LoRA metadata).

* **`batch_output_action_on_conflict`:** Currently, this defaults to `copy`. This overwrites any existing tags with the inference results, and it has screwed my manually created tags twice (though, objectively, this was my mistake). **It would likely be better to default to `ignore`**, preserving existing tags, and allow users to manually select the `copy` mode when they intentionally want to overwrite them.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.