AdguardTeam / AdguardTeam/gomitmproxy

Request body missing in OnResponse handler due to RoundTripper consumption

Ouverte
#28 0 commentaires 1 réaction 0 personnes assignées Voir sur GitHub
Langage dominant
Go
Étoiles
344
Forks
71
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Using RoundTripper results in the request body being consumed, which means that the request retrieved with `session.Request()` in the OnResponse handler is without a body. I understand that this is how RoundTripper works in Go.

Would it be reasonable to set the consumed body back to the request within gomitmproxy at this [point](https://github.com/AdguardTeam/gomitmproxy/blob/master/proxy.go#L292)?

I need the request body within the OnResponse handler, and currently, I'm passing it through `session.SetProp` [here](https://github.com/trco/wannabe/blob/9a7c27592839d4b4448054fa1df051c1cdd0af55/handlers/wannabe_on_request.go#L73). This approach seems wrong, as I would expect the request body to be available in the OnResponse handler. However, I may be missing a reason why your code doesn't set the request body back to the request.

If you find it reasonable to add the body back to the request after RoundTripper consumes it, I'm ready to prepare a PR.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.