AdguardTeam / AdguardTeam/gomitmproxy

Request body missing in OnResponse handler due to RoundTripper consumption

Abierto
#28 0 comentarios 1 reacción 0 asignados Ver en GitHub
Lenguaje dominante
Go
Estrellas
344
Forks
71
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Using RoundTripper results in the request body being consumed, which means that the request retrieved with `session.Request()` in the OnResponse handler is without a body. I understand that this is how RoundTripper works in Go.

Would it be reasonable to set the consumed body back to the request within gomitmproxy at this [point](https://github.com/AdguardTeam/gomitmproxy/blob/master/proxy.go#L292)?

I need the request body within the OnResponse handler, and currently, I'm passing it through `session.SetProp` [here](https://github.com/trco/wannabe/blob/9a7c27592839d4b4448054fa1df051c1cdd0af55/handlers/wannabe_on_request.go#L73). This approach seems wrong, as I would expect the request body to be available in the OnResponse handler. However, I may be missing a reason why your code doesn't set the request body back to the request.

If you find it reasonable to add the body back to the request after RoundTripper consumes it, I'm ready to prepare a PR.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.