AdguardTeam / AdguardTeam/gomitmproxy

Request body missing in OnResponse handler due to RoundTripper consumption

Offen
#28 0 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Go
Sterne
344
Forks
71
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Using RoundTripper results in the request body being consumed, which means that the request retrieved with `session.Request()` in the OnResponse handler is without a body. I understand that this is how RoundTripper works in Go.

Would it be reasonable to set the consumed body back to the request within gomitmproxy at this [point](https://github.com/AdguardTeam/gomitmproxy/blob/master/proxy.go#L292)?

I need the request body within the OnResponse handler, and currently, I'm passing it through `session.SetProp` [here](https://github.com/trco/wannabe/blob/9a7c27592839d4b4448054fa1df051c1cdd0af55/handlers/wannabe_on_request.go#L73). This approach seems wrong, as I would expect the request body to be available in the OnResponse handler. However, I may be missing a reason why your code doesn't set the request body back to the request.

If you find it reasonable to add the body back to the request after RoundTripper consumes it, I'm ready to prepare a PR.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.