AdguardTeam / AdguardTeam/FiltersCompiler

trusted-* scriptlets dropped in convertToUbo() even if uBO resources include trusted scriptlets

未關閉
#273 0 則留言 0 個 reaction 已指派 1 人 已被 @maximtop 認領 在 GitHub 檢視
Priority: P4
主要語言
JavaScript
星號
64
分支
11
PR 合併指標
30 天內沒有已合併 PR

描述

I found that there's a confusion about the trusted scriptlet conversion to uBO format.

In `FiltersCompiler`, this code explicitly skips trusted scriptlets when converting to uBO:

- https://github.com/AdguardTeam/FiltersCompiler/blob/4ab18cd54fc4c7313d0e2c5e788ed5fa01c2c98b/src/main/converter.js#L131-L136

At the same time, uBO’s Resources Library documents trusted scriptlets (for example `trusted-click-element`, `trusted-set-session-storage-item`, etc.), and they mention the Adguard website, which indicates the correspondence:

- https://github.com/gorhill/ublock/wiki/Resources-Library#trusted-click-elementjs-

So I’m trying to understand the rationale in `FiltersCompiler`. Is this an intentional policy decision (e.g., trust-source/security model mismatch) rather than a technical capability mismatch? Or is it just outdated information?

If it's the latter case, would it make sense add conversion support for trusted scriptlets?

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。