AdguardTeam / AdguardTeam/FiltersCompiler

trusted-* scriptlets dropped in convertToUbo() even if uBO resources include trusted scriptlets

Open
#273 0 comments 0 reactions 1 assignee Claimed by @maximtop View on GitHub
Priority: P4
Dominant language
JavaScript
Stars
64
Forks
11
PR merge metrics
No merged PRs in 30d

Description

I found that there's a confusion about the trusted scriptlet conversion to uBO format.

In `FiltersCompiler`, this code explicitly skips trusted scriptlets when converting to uBO:

- https://github.com/AdguardTeam/FiltersCompiler/blob/4ab18cd54fc4c7313d0e2c5e788ed5fa01c2c98b/src/main/converter.js#L131-L136

At the same time, uBO’s Resources Library documents trusted scriptlets (for example `trusted-click-element`, `trusted-set-session-storage-item`, etc.), and they mention the Adguard website, which indicates the correspondence:

- https://github.com/gorhill/ublock/wiki/Resources-Library#trusted-click-elementjs-

So I’m trying to understand the rationale in `FiltersCompiler`. Is this an intentional policy decision (e.g., trust-source/security model mismatch) rather than a technical capability mismatch? Or is it just outdated information?

If it's the latter case, would it make sense add conversion support for trusted scriptlets?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.