AdguardTeam / AdguardTeam/FiltersCompiler
trusted-* scriptlets dropped in convertToUbo() even if uBO resources include trusted scriptlets
- Langage dominant
- JavaScript
- Étoiles
- 64
- Forks
- 11
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
I found that there's a confusion about the trusted scriptlet conversion to uBO format.
In `FiltersCompiler`, this code explicitly skips trusted scriptlets when converting to uBO:
- https://github.com/AdguardTeam/FiltersCompiler/blob/4ab18cd54fc4c7313d0e2c5e788ed5fa01c2c98b/src/main/converter.js#L131-L136
At the same time, uBO’s Resources Library documents trusted scriptlets (for example `trusted-click-element`, `trusted-set-session-storage-item`, etc.), and they mention the Adguard website, which indicates the correspondence:
- https://github.com/gorhill/ublock/wiki/Resources-Library#trusted-click-elementjs-
So I’m trying to understand the rationale in `FiltersCompiler`. Is this an intentional policy decision (e.g., trust-source/security model mismatch) rather than a technical capability mismatch? Or is it just outdated information?
If it's the latter case, would it make sense add conversion support for trusted scriptlets?
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Évaluation
Cette issue n'a pas encore été évaluée.