AdguardTeam / AdguardTeam/AdGuardHome

Do not show 'port 443 is not available' error notification if encryption is not enabled (again)

Aperta
#2,407 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub
bug P3: Medium UI
Lingua principale
TypeScript
Stelle
36.9k
Fork
2.5k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Steps to reproduce

Install AdGuard Home on a system where port 443 is already in use.
Open AdGuard Home settings page.
Observe the red error notification with the message "Error: control/tls/validate | port 443 is not available, cannot enable HTTPS on it | 400".

Expected behavior

If "Enable Encryption" option is disabled, do not show any error notifications related to unavailable ports specified on this section.

Actual behavior

If "Enable Encryption" option is disabled, error notifications related to unavailable ports specified on this section are still shown even though the option is disabled and not being used.

Screenshot:
![imagen](https://user-images.githubusercontent.com/30116095/101559195-edbca780-39c0-11eb-81ac-bdac22df1129.png)

Your environment

Description | Value
-- | --
Version of AdGuard Home server: | (v0.104.1)

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.