AdguardTeam / AdguardTeam/AdGuardHome

Do not show 'port 443 is not available' error notification if encryption is not enabled (again)

Abierto
#2,407 3 comentarios 0 reacciones 0 asignados Ver en GitHub
bug P3: Medium UI
Lenguaje dominante
TypeScript
Estrellas
36.9k
Forks
2.5k
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Steps to reproduce

Install AdGuard Home on a system where port 443 is already in use.
Open AdGuard Home settings page.
Observe the red error notification with the message "Error: control/tls/validate | port 443 is not available, cannot enable HTTPS on it | 400".

Expected behavior

If "Enable Encryption" option is disabled, do not show any error notifications related to unavailable ports specified on this section.

Actual behavior

If "Enable Encryption" option is disabled, error notifications related to unavailable ports specified on this section are still shown even though the option is disabled and not being used.

Screenshot:
![imagen](https://user-images.githubusercontent.com/30116095/101559195-edbca780-39c0-11eb-81ac-bdac22df1129.png)

Your environment

Description | Value
-- | --
Version of AdGuard Home server: | (v0.104.1)

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.