AdguardTeam / AdguardTeam/AdGuardHome

Do not show 'port 443 is not available' error notification if encryption is not enabled (again)

Ouverte
#2,407 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
bug P3: Medium UI
Langage dominant
TypeScript
Étoiles
36.9k
Forks
2.5k
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Steps to reproduce

Install AdGuard Home on a system where port 443 is already in use.
Open AdGuard Home settings page.
Observe the red error notification with the message "Error: control/tls/validate | port 443 is not available, cannot enable HTTPS on it | 400".

Expected behavior

If "Enable Encryption" option is disabled, do not show any error notifications related to unavailable ports specified on this section.

Actual behavior

If "Enable Encryption" option is disabled, error notifications related to unavailable ports specified on this section are still shown even though the option is disabled and not being used.

Screenshot:
![imagen](https://user-images.githubusercontent.com/30116095/101559195-edbca780-39c0-11eb-81ac-bdac22df1129.png)

Your environment

Description | Value
-- | --
Version of AdGuard Home server: | (v0.104.1)

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.