AdevintaSpain / AdevintaSpain/TaggingViewer

Unintuitive spaces when activity separator is disabled

未关闭
#8 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
enhancement question
主要语言
Kotlin
星标
8
派生
1
PR 合并指标
30 天内没有已合并 PR

描述

When "named separator" is disabled, the overlay doesn't show activity names but instead adds a space between events.

My application uses a mix of activity and fragment navigation, so these spaces are completely inconsistent. Also, since the event list is limited to 10, they remove valuable space from the event list. If I have 5 activity navigations, the overlay can only display 5 events. It even accumulates spaces (can't reproduce that in the sample).

My suggestion is to remove this space completely. In my opinion, it makes no sense to disable the separators but still have them occupying space. An alternative is to add another option to disable the spaces, but I think that would complicate the API too much.

I can open a PR for this, but I'd like to know what do the owners think first.
https://github.com/AdevintaSpain/TaggingViewer/blob/main/taggingviewer/src/main/java/com/adevinta/android/taggingviewer/TaggingViewer.kt#L35

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。