AdevintaSpain / AdevintaSpain/TaggingViewer

Unintuitive spaces when activity separator is disabled

Đang mở
#8 2 bình luận 0 reaction 0 người được giao Xem trên GitHub
enhancement question
Ngôn ngữ chính
Kotlin
Star
8
Fork
1
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

When "named separator" is disabled, the overlay doesn't show activity names but instead adds a space between events.

My application uses a mix of activity and fragment navigation, so these spaces are completely inconsistent. Also, since the event list is limited to 10, they remove valuable space from the event list. If I have 5 activity navigations, the overlay can only display 5 events. It even accumulates spaces (can't reproduce that in the sample).

My suggestion is to remove this space completely. In my opinion, it makes no sense to disable the separators but still have them occupying space. An alternative is to add another option to disable the spaces, but I think that would complicate the API too much.

I can open a PR for this, but I'd like to know what do the owners think first.
https://github.com/AdevintaSpain/TaggingViewer/blob/main/taggingviewer/src/main/java/com/adevinta/android/taggingviewer/TaggingViewer.kt#L35

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.