AdevintaSpain / AdevintaSpain/TaggingViewer

Unintuitive spaces when activity separator is disabled

Offen
#8 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
enhancement question
Vorherrschende Sprache
Kotlin
Sterne
8
Forks
1
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

When "named separator" is disabled, the overlay doesn't show activity names but instead adds a space between events.

My application uses a mix of activity and fragment navigation, so these spaces are completely inconsistent. Also, since the event list is limited to 10, they remove valuable space from the event list. If I have 5 activity navigations, the overlay can only display 5 events. It even accumulates spaces (can't reproduce that in the sample).

My suggestion is to remove this space completely. In my opinion, it makes no sense to disable the separators but still have them occupying space. An alternative is to add another option to disable the spaces, but I think that would complicate the API too much.

I can open a PR for this, but I'd like to know what do the owners think first.
https://github.com/AdevintaSpain/TaggingViewer/blob/main/taggingviewer/src/main/java/com/adevinta/android/taggingviewer/TaggingViewer.kt#L35

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.