AcademySoftwareFoundation / AcademySoftwareFoundation/OpenColorIO

Many tests fail when compiling with -march

オープン
#2,146 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
C++
スター
2.1k
フォーク
503
PR マージ指標
30日以内にマージされた PR はありません

説明

```
8 tests failed with 33 errors 21 skips.


Start 9: test_cpu_avx512
9/10 Test #9: test_cpu_avx512 .................. Passed 0.00 sec
Start 10: test_python
10/10 Test #10: test_python ...................... Passed 0.35 sec

30% tests passed, 7 tests failed out of 10

Total Test time (real) = 10.73 sec

The following tests FAILED:
2 - test_cpu (Failed)
3 - test_cpu_no_accel (Failed)
4 - test_cpu_sse2 (Failed)
5 - test_cpu_avx (Failed)
6 - test_cpu_avx+f16c (Failed)
7 - test_cpu_avx2 (Failed)
8 - test_cpu_avx2+f16c (Failed)
Errors while running CTest
make: *** [Makefile:71: test] Error 8
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:123:
FAILED: Index: 17 - Values: 0.896949828 and: 0.896951199 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:123:
FAILED: Index: 21 - Values: 1.10895336 and: 1.10895324 - Threshold: 1.00000001e-07
[ 694/1098] [GammaOpCPU / apply_basic_style_fwd ] - FAILED
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:187:
FAILED: Index: 16 - Values: 0.830311298 and: 0.830311418 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:187:
FAILED: Index: 17 - Values: 0.976092517 and: 0.976092875 - Threshold: 1.00000001e-07
[ 695/1098] [GammaOpCPU / apply_basic_style_rev ] - FAILED
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:279:
FAILED: Index: 17 - Values: 0.896949828 and: 0.896951199 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:279:
FAILED: Index: 21 - Values: -0.896949828 and: -0.896951199 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:279:
FAILED: Index: 25 - Values: 1.10895336 and: 1.10895324 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:279:
FAILED: Index: 29 - Values: -1.10895336 and: -1.10895324 - Threshold: 1.00000001e-07
[ 696/1098] [GammaOpCPU / apply_basic_mirror_style_fwd ] - FAILED
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:370:
FAILED: Index: 16 - Values: 0.830311298 and: 0.830311418 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:370:
FAILED: Index: 17 - Values: 0.976092517 and: 0.976092875 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:370:
FAILED: Index: 20 - Values: -0.830311298 and: -0.830311418 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:370:
FAILED: Index: 21 - Values: -0.976092517 and: -0.976092875 - Threshold: 1.00000001e-07
[ 697/1098] [GammaOpCPU / apply_basic_mirror_style_rev ] - FAILED
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:449:
FAILED: Index: 17 - Values: 0.896949828 and: 0.896951199 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:449:
FAILED: Index: 25 - Values: 1.10895336 and: 1.10895324 - Threshold: 1.00000001e-07
[ 698/1098] [GammaOpCPU / apply_basic_pass_thru_style_fwd ] - FAILED
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:528:
FAILED: Index: 16 - Values: 0.830311298 and: 0.830311418 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:528:
FAILED: Index: 17 - Values: 0.976092517 and: 0.976092875 - Threshold: 1.00000001e-07
[ 699/1098] [GammaOpCPU / apply_basic_pass_thru_style_rev ] - FAILED
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:583:
FAILED: Index: 16 - Values: 0.60383141 and: 0.603831291 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:583:
FAILED: Index: 17 - Values: 0.910603881 and: 0.91060406 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:583:
FAILED: Index: 20 - Values: 1.01142669 and: 1.01142657 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:583:
FAILED: Index: 21 - Values: 1.09394491 and: 1.09394503 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:583:
FAILED: Index: 22 - Values: 1.49998474 and: 1.49998403 - Threshold: 1.00000001e-07
[ 700/1098] [GammaOpCPU / apply_moncurve_style_fwd ] - FAILED
[ 701/1098] [GammaOpCPU / apply_moncurve_style_rev ] - PASSED
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 10 - Values: 0.674750805 and: 0.674750686 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 14 - Values: -0.674750805 and: -0.674750686 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 16 - Values: 0.60383141 and: 0.603831291 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 17 - Values: 0.910603881 and: 0.91060406 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 20 - Values: -0.60383141 and: -0.603831291 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 21 - Values: -0.910603881 and: -0.91060406 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 24 - Values: 1.01142669 and: 1.01142657 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 25 - Values: 1.09394491 and: 1.09394503 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 26 - Values: 1.84183896 and: 1.84183872 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 28 - Values: -1.01142669 and: -1.01142657 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 29 - Values: -1.09394491 and: -1.09394503 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
# FAILED: Index: 30 - Values: -1.84183896 and: -1.84183872 - Threshold: 1.00000001e-07
```

Specifically with `-march=alderlake`. Maybe you would want to open up the thresholds on all of these to support setting the march optimizations

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

-march=alderlakeを使用してCTestまたはmake testターゲットで失敗を再現し、その後、報告されたアサーションについてtests/cpu/ops/gamma/GammaOpCPU_tests.cppを調査します。gammaの各ケースで失敗している値としきい値を比較し、このアーキテクチャに合わせて許容誤差を調整すべきか判断します。完了とは、報告された最適化を使用して、関連するCPUテストが他の無関係な失敗を隠すことなくパスすることです。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
cpp
領域
testing
issue の種類
バグ
難易度
3/5
見積もり時間
1〜2日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
42/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。