AcademySoftwareFoundation / AcademySoftwareFoundation/OpenColorIO

Many tests fail when compiling with -march

Abierto
#2,146 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
C++
Estrellas
2.1k
Forks
503
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

```
8 tests failed with 33 errors 21 skips.


Start 9: test_cpu_avx512
9/10 Test #9: test_cpu_avx512 .................. Passed 0.00 sec
Start 10: test_python
10/10 Test #10: test_python ...................... Passed 0.35 sec

30% tests passed, 7 tests failed out of 10

Total Test time (real) = 10.73 sec

The following tests FAILED:
2 - test_cpu (Failed)
3 - test_cpu_no_accel (Failed)
4 - test_cpu_sse2 (Failed)
5 - test_cpu_avx (Failed)
6 - test_cpu_avx+f16c (Failed)
7 - test_cpu_avx2 (Failed)
8 - test_cpu_avx2+f16c (Failed)
Errors while running CTest
make: *** [Makefile:71: test] Error 8
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:123:
FAILED: Index: 17 - Values: 0.896949828 and: 0.896951199 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:123:
FAILED: Index: 21 - Values: 1.10895336 and: 1.10895324 - Threshold: 1.00000001e-07
[ 694/1098] [GammaOpCPU / apply_basic_style_fwd ] - FAILED
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:187:
FAILED: Index: 16 - Values: 0.830311298 and: 0.830311418 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:187:
FAILED: Index: 17 - Values: 0.976092517 and: 0.976092875 - Threshold: 1.00000001e-07
[ 695/1098] [GammaOpCPU / apply_basic_style_rev ] - FAILED
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:279:
FAILED: Index: 17 - Values: 0.896949828 and: 0.896951199 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:279:
FAILED: Index: 21 - Values: -0.896949828 and: -0.896951199 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:279:
FAILED: Index: 25 - Values: 1.10895336 and: 1.10895324 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:279:
FAILED: Index: 29 - Values: -1.10895336 and: -1.10895324 - Threshold: 1.00000001e-07
[ 696/1098] [GammaOpCPU / apply_basic_mirror_style_fwd ] - FAILED
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:370:
FAILED: Index: 16 - Values: 0.830311298 and: 0.830311418 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:370:
FAILED: Index: 17 - Values: 0.976092517 and: 0.976092875 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:370:
FAILED: Index: 20 - Values: -0.830311298 and: -0.830311418 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:370:
FAILED: Index: 21 - Values: -0.976092517 and: -0.976092875 - Threshold: 1.00000001e-07
[ 697/1098] [GammaOpCPU / apply_basic_mirror_style_rev ] - FAILED
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:449:
FAILED: Index: 17 - Values: 0.896949828 and: 0.896951199 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:449:
FAILED: Index: 25 - Values: 1.10895336 and: 1.10895324 - Threshold: 1.00000001e-07
[ 698/1098] [GammaOpCPU / apply_basic_pass_thru_style_fwd ] - FAILED
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:528:
FAILED: Index: 16 - Values: 0.830311298 and: 0.830311418 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:528:
FAILED: Index: 17 - Values: 0.976092517 and: 0.976092875 - Threshold: 1.00000001e-07
[ 699/1098] [GammaOpCPU / apply_basic_pass_thru_style_rev ] - FAILED
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:583:
FAILED: Index: 16 - Values: 0.60383141 and: 0.603831291 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:583:
FAILED: Index: 17 - Values: 0.910603881 and: 0.91060406 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:583:
FAILED: Index: 20 - Values: 1.01142669 and: 1.01142657 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:583:
FAILED: Index: 21 - Values: 1.09394491 and: 1.09394503 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:583:
FAILED: Index: 22 - Values: 1.49998474 and: 1.49998403 - Threshold: 1.00000001e-07
[ 700/1098] [GammaOpCPU / apply_moncurve_style_fwd ] - FAILED
[ 701/1098] [GammaOpCPU / apply_moncurve_style_rev ] - PASSED
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 10 - Values: 0.674750805 and: 0.674750686 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 14 - Values: -0.674750805 and: -0.674750686 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 16 - Values: 0.60383141 and: 0.603831291 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 17 - Values: 0.910603881 and: 0.91060406 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 20 - Values: -0.60383141 and: -0.603831291 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 21 - Values: -0.910603881 and: -0.91060406 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 24 - Values: 1.01142669 and: 1.01142657 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 25 - Values: 1.09394491 and: 1.09394503 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 26 - Values: 1.84183896 and: 1.84183872 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 28 - Values: -1.01142669 and: -1.01142657 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
FAILED: Index: 29 - Values: -1.09394491 and: -1.09394503 - Threshold: 1.00000001e-07
/build/source/tests/cpu/ops/gamma/GammaOpCPU_tests.cpp:699:
# FAILED: Index: 30 - Values: -1.84183896 and: -1.84183872 - Threshold: 1.00000001e-07
```

Specifically with `-march=alderlake`. Maybe you would want to open up the thresholds on all of these to support setting the march optimizations

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Reproduce el fallo con el objetivo CTest o make test usando -march=alderlake y, después, inspecciona tests/cpu/ops/gamma/GammaOpCPU_tests.cpp en las aserciones indicadas. Compara los valores y umbrales que fallan entre los casos gamma y determina si la tolerancia debería adaptarse a esta arquitectura. Se considera terminado cuando las pruebas de CPU afectadas pasan con la optimización indicada sin ocultar fallos no relacionados.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
cpp
Área
testing
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
42/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.