AbsaOSS / AbsaOSS/hyperdrive

Rename prefix for additional properties for KafkaStreamReader

Aperta
#91 1 commento 1 reazione 1 assegnatario Assegnata a @kevinwallimann Vedi su GitHub
breaking-changes
Lingua principale
Scala
Stelle
47
Fork
14
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Currently, additional properties for the `KafkaStreamReader` have to be specified with the prefix `reader.options.` E.g. `reader.options.kafka.security.protocol` or `reader.options.kafka.ssl.key.password`

This prefix is inconsistent with all other properties which start with `decoder.avro.`, `writer.parquet.`, `manager.checkpoint` or `transformer.columns.`. The properties for the `KafkaStreamReader` should start with `reader.kafka.`, i.e. `reader.kafka.options.kafka.security.protocol`.

For additional properties like `reader.options.failOnDataLoss` or `reader.options.minPartitions` it's hard to find out which reader implementation they belong to.

**Tasks**
- Change prefix for additional properties for `KafkaStreamReader` to `reader.kafka.options.`

**How to migrate**
- All property keys starting with `reader.options` have to be replaced by `reader.kafka.options`

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.