AbsaOSS / AbsaOSS/hyperdrive

Rename prefix for additional properties for KafkaStreamReader

Ouverte
#91 1 commentaire 1 réaction 1 personne assignée Assignée à @kevinwallimann Voir sur GitHub
breaking-changes
Langage dominant
Scala
Étoiles
47
Forks
14
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Currently, additional properties for the `KafkaStreamReader` have to be specified with the prefix `reader.options.` E.g. `reader.options.kafka.security.protocol` or `reader.options.kafka.ssl.key.password`

This prefix is inconsistent with all other properties which start with `decoder.avro.`, `writer.parquet.`, `manager.checkpoint` or `transformer.columns.`. The properties for the `KafkaStreamReader` should start with `reader.kafka.`, i.e. `reader.kafka.options.kafka.security.protocol`.

For additional properties like `reader.options.failOnDataLoss` or `reader.options.minPartitions` it's hard to find out which reader implementation they belong to.

**Tasks**
- Change prefix for additional properties for `KafkaStreamReader` to `reader.kafka.options.`

**How to migrate**
- All property keys starting with `reader.options` have to be replaced by `reader.kafka.options`

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.