AbsaOSS / AbsaOSS/hyperdrive

Rename prefix for additional properties for KafkaStreamReader

Abierto
#91 1 comentario 1 reacción 1 asignado Asignado a @kevinwallimann Ver en GitHub
breaking-changes
Lenguaje dominante
Scala
Estrellas
47
Forks
14
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Currently, additional properties for the `KafkaStreamReader` have to be specified with the prefix `reader.options.` E.g. `reader.options.kafka.security.protocol` or `reader.options.kafka.ssl.key.password`

This prefix is inconsistent with all other properties which start with `decoder.avro.`, `writer.parquet.`, `manager.checkpoint` or `transformer.columns.`. The properties for the `KafkaStreamReader` should start with `reader.kafka.`, i.e. `reader.kafka.options.kafka.security.protocol`.

For additional properties like `reader.options.failOnDataLoss` or `reader.options.minPartitions` it's hard to find out which reader implementation they belong to.

**Tasks**
- Change prefix for additional properties for `KafkaStreamReader` to `reader.kafka.options.`

**How to migrate**
- All property keys starting with `reader.options` have to be replaced by `reader.kafka.options`

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.