5e-bits / 5e-bits/5e-database

Improvement idea: add `choice` prop to features giving a subclass

未關閉
#260 6 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
TypeScript
星號
934
分支
427
平均合併
17 小時 25 分鐘
30 天內合併 PR
22

描述

Just like the title says. There are feautres, where you choose something form an array of opitons, be it expertise, eldritch invocation or fighting style. Why not treat subclasses the same way?

Proposed structure:
```
{
"index": "otherworldly-patron",
"class": {
"index": "warlock",
"name": "Warlock",
"url": "/api/classes/warlock"
},
"name": "Otherworldly Patron",
"level": 1,
"desc": [
"At 1st level [yada yada]."
],
"choice: {
"choose": 1,
"type": subclass
from: "api/classes/warlock/subclasses"
}
"url": "/api/features/otherworldly-patron"
}
```

I know there is only one subclass in the SRD, but as y'all mentioned before, if something comes from a feature, you like to keep it within that feature, so why not add information about subclass choices to the feature giving you a subclass?

貢獻指南

開啟貢獻指南

研究方向

Examine the feature data structure in the repository, likely in a JSON file or TypeScript interface. Look for existing features with a 'choice' property to understand the pattern. The change involves adding a new 'choice' object with type 'subclass' and a 'from' URL. Check how subclasses are currently referenced and ensure the new structure aligns with the API design. Test by updating a sample feature and verifying the API response.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
json, typescript
領域
api, database
Issue 類型
功能
難度
3/5
預估耗時
1-2 天
活躍度
停滯
描述清晰度
描述清楚
新手友好度
55/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。