5e-bits / 5e-bits/5e-database

Improvement idea: add `choice` prop to features giving a subclass

Aberta
#260 6 comentários 0 reações 0 responsáveis Ver no GitHub
Linguagem predominante
TypeScript
Estrelas
934
Forks
427
Merge médio
17h 25min
PRs com merge (30d)
22

Descrição

Just like the title says. There are feautres, where you choose something form an array of opitons, be it expertise, eldritch invocation or fighting style. Why not treat subclasses the same way?

Proposed structure:
```
{
"index": "otherworldly-patron",
"class": {
"index": "warlock",
"name": "Warlock",
"url": "/api/classes/warlock"
},
"name": "Otherworldly Patron",
"level": 1,
"desc": [
"At 1st level [yada yada]."
],
"choice: {
"choose": 1,
"type": subclass
from: "api/classes/warlock/subclasses"
}
"url": "/api/features/otherworldly-patron"
}
```

I know there is only one subclass in the SRD, but as y'all mentioned before, if something comes from a feature, you like to keep it within that feature, so why not add information about subclass choices to the feature giving you a subclass?

Guia de contribuição

Abrir o guia de contribuição

Direção de pesquisa

Examine the feature data structure in the repository, likely in a JSON file or TypeScript interface. Look for existing features with a 'choice' property to understand the pattern. The change involves adding a new 'choice' object with type 'subclass' and a 'from' URL. Check how subclasses are currently referenced and ensure the new structure aligns with the API design. Test by updating a sample feature and verifying the API response.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
json, typescript
Domínio
api, database
Tipo de issue
Funcionalidade
Dificuldade
3/5
Tempo estimado
1-2 dias
Status de atividade
Estagnada
Clareza
Claramente especificada
Facilidade para iniciantes
55/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.