5e-bits / 5e-bits/5e-database

Improvement idea: add `choice` prop to features giving a subclass

Ouverte
#260 6 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
TypeScript
Étoiles
934
Forks
427
Merge moyen
17 h 25 min
PR mergées (30 j)
22

Description

Just like the title says. There are feautres, where you choose something form an array of opitons, be it expertise, eldritch invocation or fighting style. Why not treat subclasses the same way?

Proposed structure:
```
{
"index": "otherworldly-patron",
"class": {
"index": "warlock",
"name": "Warlock",
"url": "/api/classes/warlock"
},
"name": "Otherworldly Patron",
"level": 1,
"desc": [
"At 1st level [yada yada]."
],
"choice: {
"choose": 1,
"type": subclass
from: "api/classes/warlock/subclasses"
}
"url": "/api/features/otherworldly-patron"
}
```

I know there is only one subclass in the SRD, but as y'all mentioned before, if something comes from a feature, you like to keep it within that feature, so why not add information about subclass choices to the feature giving you a subclass?

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Examine the feature data structure in the repository, likely in a JSON file or TypeScript interface. Look for existing features with a 'choice' property to understand the pattern. The change involves adding a new 'choice' object with type 'subclass' and a 'from' URL. Check how subclasses are currently referenced and ensure the new structure aligns with the API design. Test by updating a sample feature and verifying the API response.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
json, typescript
Domaine
api, database
Type d'issue
Fonctionnalité
Difficulté
3/5
Temps estimé
1-2 jours
Activité
À l'abandon
Clarté
Clairement spécifiée
Accessibilité débutants
55/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.