4paradigm / 4paradigm/OpenMLDB

build(clean): allow delete proto/swig generated files in project

未关闭 适合新手
#891 8 条评论 2 个 reaction 已指派 1 人 已被 @aceforeverd 认领 在 GitHub 查看
bug build
主要语言
C++
星标
1.7k
派生
331
平均合并
12 天 12 小时
30 天内合并 PR
1

描述

two minor bugs in Makefile:
- `make clean` doesn't clean the swig genereated files
- `HYBRIDSE_CMAKE_DEPS_FLAGS := -DHYBRIDSE_TESTING_ENABLE=OFF -DEXAMPLES_ENABLE=OFF -DPYSDK_ENABLE=OFF -DJAVASDK_ENABLE=OFF`
these options are cached, simply overriding cannot change these values.

## Expected Behavior
- `make clean` at least provide an option to clean the generated files, including swig, proto and so on.
- By simply `make JAVASDK_ENABLE=ON`, we can make the hybridse javasdk

## Current Behavior
- `make clean` only delete the `build` and `hybridse/build`
- `make JAVASDK_ENABLE=ON` does not work as expected

贡献指南

打开贡献指南

调研方向

Look at the project's Makefile, likely in the root directory. Identify the 'clean' target and the variables for HYBRIDSE_CMAKE_DEPS_FLAGS. For the clean target, add commands to remove proto and swig generated files (check typical locations like 'src/proto' or 'swig' directories). For the CMake flags, ensure they are not cached by using 'unset' or passing them as command-line arguments without caching. Test by running 'make clean' and 'make JAVASDK_ENABLE=ON' to verify the changes work.

由索引模型根据 Issue 内容生成。

评估

技术栈
cmake, cpp
领域
build-system, tooling
Issue 类型
缺陷
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
描述清楚
新手友好度
65/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。