4paradigm / 4paradigm/OpenMLDB
build(clean): allow delete proto/swig generated files in project
- Lenguaje dominante
- C++
- Estrellas
- 1.7k
- Forks
- 331
- Merge medio
- 12 d 12 h
- PR fusionados (30 d)
- 1
Descripción
two minor bugs in Makefile:
- `make clean` doesn't clean the swig genereated files
- `HYBRIDSE_CMAKE_DEPS_FLAGS := -DHYBRIDSE_TESTING_ENABLE=OFF -DEXAMPLES_ENABLE=OFF -DPYSDK_ENABLE=OFF -DJAVASDK_ENABLE=OFF`
these options are cached, simply overriding cannot change these values.
## Expected Behavior
- `make clean` at least provide an option to clean the generated files, including swig, proto and so on.
- By simply `make JAVASDK_ENABLE=ON`, we can make the hybridse javasdk
## Current Behavior
- `make clean` only delete the `build` and `hybridse/build`
- `make JAVASDK_ENABLE=ON` does not work as expected
Guía de contribución
Línea de trabajo
Look at the project's Makefile, likely in the root directory. Identify the 'clean' target and the variables for HYBRIDSE_CMAKE_DEPS_FLAGS. For the clean target, add commands to remove proto and swig generated files (check typical locations like 'src/proto' or 'swig' directories). For the CMake flags, ensure they are not cached by using 'unset' or passing them as command-line arguments without caching. Test by running 'make clean' and 'make JAVASDK_ENABLE=ON' to verify the changes work.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- cmake, cpp
- Área
- build-system, tooling
- Tipo de issue
- Error
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Estado de actividad
- Estancado
- Claridad
- Bien especificado
- Aptitud para principiantes
- 65/100