4paradigm / 4paradigm/OpenMLDB

build(clean): allow delete proto/swig generated files in project

Aberta Para iniciantes
#891 8 comentários 2 reações 1 responsável Reivindicada por @aceforeverd Ver no GitHub
bug build
Linguagem predominante
C++
Estrelas
1.7k
Forks
331
Merge médio
12d 12h
PRs com merge (30d)
1

Descrição

two minor bugs in Makefile:
- `make clean` doesn't clean the swig genereated files
- `HYBRIDSE_CMAKE_DEPS_FLAGS := -DHYBRIDSE_TESTING_ENABLE=OFF -DEXAMPLES_ENABLE=OFF -DPYSDK_ENABLE=OFF -DJAVASDK_ENABLE=OFF`
these options are cached, simply overriding cannot change these values.

## Expected Behavior
- `make clean` at least provide an option to clean the generated files, including swig, proto and so on.
- By simply `make JAVASDK_ENABLE=ON`, we can make the hybridse javasdk

## Current Behavior
- `make clean` only delete the `build` and `hybridse/build`
- `make JAVASDK_ENABLE=ON` does not work as expected

Guia de contribuição

Abrir o guia de contribuição

Direção de pesquisa

Look at the project's Makefile, likely in the root directory. Identify the 'clean' target and the variables for HYBRIDSE_CMAKE_DEPS_FLAGS. For the clean target, add commands to remove proto and swig generated files (check typical locations like 'src/proto' or 'swig' directories). For the CMake flags, ensure they are not cached by using 'unset' or passing them as command-line arguments without caching. Test by running 'make clean' and 'make JAVASDK_ENABLE=ON' to verify the changes work.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
cmake, cpp
Domínio
build-system, tooling
Tipo de issue
Bug
Dificuldade
2/5
Tempo estimado
1-3 horas
Status de atividade
Estagnada
Clareza
Claramente especificada
Facilidade para iniciantes
65/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.