4paradigm / 4paradigm/OpenMLDB
Support null equal in last join for openmldb-batch
- Langage dominant
- C++
- Étoiles
- 1.7k
- Forks
- 331
- Merge moyen
- 12 j 12 h
- PR mergées (30 j)
- 1
Description
We may support `===` and `<=>` for last join.
```
--- a/java/openmldb-batch/src/main/scala/com/_4paradigm/openmldb/batch/nodes/JoinPlan.scala
+++ b/java/openmldb-batch/src/main/scala/com/_4paradigm/openmldb/batch/nodes/JoinPlan.scala
@@ -91,10 +91,18 @@ object JoinPlan {
for (i <- 0 until keyNum) {
val leftColumn = SparkColumnUtil.resolveExprNodeToColumn(leftKeys.GetChild(i), node.GetProducer(0), leftDf)
val rightColumn = SparkColumnUtil.resolveExprNodeToColumn(rightKeys.GetChild(i), node.GetProducer(1), rightDf)
- joinConditions += (leftColumn === rightColumn)
+ joinConditions += leftColumn.eqNullSafe(rightColumn)
}
}
```
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
The change is in JoinPlan.scala, specifically the join condition logic. Start by understanding the existing last join implementation and how null equality is currently handled. Look at the SparkColumnUtil and the eqNullSafe method. Run tests related to join operations to verify the new behavior.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- scala, spark
- Domaine
- databases, machine-learning
- Type d'issue
- Fonctionnalité
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 45/100