404labfr / 404labfr/laravel-impersonate

Blade directives not working

未关闭
#153 3 条评论 3 个 reaction 已指派 0 人 在 GitHub 查看
bug next version
主要语言
PHP
星标
2.3k
派生
235
PR 合并指标
30 天内没有已合并 PR

描述

I noticed that the Blade directives such as `@impersonating()` and `@endImpersonating()` stooped working, instead they were being rendered as HTML on the frontend.

After some digging and debugging I found out that the "problem" lies in the way that the directives are registered.
I also found a way to fix the issue, but I admit that I'm not sure about the technical reason behind the problem, I didn't have time to dig more into it.

Note: The issue started after the Laravel 9 upgrade.

**Actual implementation:**
```php
public function register()
{
...
$this->registerBladeDirectives();
...
}

protected function registerBladeDirectives()
{
$this->app->afterResolving('blade.compiler', function (BladeCompiler $bladeCompiler) {
/// register the Blade directives
});
}
```

**My fix:**
```php
public function boot(): void
{
...
if ($this->app->resolved('blade.compiler')) {
$this->registerImpersonateDirectives($this->app['blade.compiler']);
} else {
$this->app->afterResolving('blade.compiler', function (BladeCompiler $bladeCompiler) {
$this->registerImpersonateDirectives($bladeCompiler);
});
}
```

**What also works:**
If it's really necessary to place the directive declaration inside the `register` method, do not wrap it with the `...afterResolving('blade.compiler',...` callback, that also worked with my tests.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。