404labfr / 404labfr/laravel-impersonate

Blade directives not working

Aperta
#153 3 commenti 3 reazioni 0 assegnatari Vedi su GitHub
bug next version
Lingua principale
PHP
Stelle
2.3k
Fork
235
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I noticed that the Blade directives such as `@impersonating()` and `@endImpersonating()` stooped working, instead they were being rendered as HTML on the frontend.

After some digging and debugging I found out that the "problem" lies in the way that the directives are registered.
I also found a way to fix the issue, but I admit that I'm not sure about the technical reason behind the problem, I didn't have time to dig more into it.

Note: The issue started after the Laravel 9 upgrade.

**Actual implementation:**
```php
public function register()
{
...
$this->registerBladeDirectives();
...
}

protected function registerBladeDirectives()
{
$this->app->afterResolving('blade.compiler', function (BladeCompiler $bladeCompiler) {
/// register the Blade directives
});
}
```

**My fix:**
```php
public function boot(): void
{
...
if ($this->app->resolved('blade.compiler')) {
$this->registerImpersonateDirectives($this->app['blade.compiler']);
} else {
$this->app->afterResolving('blade.compiler', function (BladeCompiler $bladeCompiler) {
$this->registerImpersonateDirectives($bladeCompiler);
});
}
```

**What also works:**
If it's really necessary to place the directive declaration inside the `register` method, do not wrap it with the `...afterResolving('blade.compiler',...` callback, that also worked with my tests.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.