404labfr / 404labfr/laravel-impersonate
Blade directives not working
- Langage dominant
- PHP
- Étoiles
- 2.3k
- Forks
- 235
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
I noticed that the Blade directives such as `@impersonating()` and `@endImpersonating()` stooped working, instead they were being rendered as HTML on the frontend.
After some digging and debugging I found out that the "problem" lies in the way that the directives are registered.
I also found a way to fix the issue, but I admit that I'm not sure about the technical reason behind the problem, I didn't have time to dig more into it.
Note: The issue started after the Laravel 9 upgrade.
**Actual implementation:**
```php
public function register()
{
...
$this->registerBladeDirectives();
...
}
protected function registerBladeDirectives()
{
$this->app->afterResolving('blade.compiler', function (BladeCompiler $bladeCompiler) {
/// register the Blade directives
});
}
```
**My fix:**
```php
public function boot(): void
{
...
if ($this->app->resolved('blade.compiler')) {
$this->registerImpersonateDirectives($this->app['blade.compiler']);
} else {
$this->app->afterResolving('blade.compiler', function (BladeCompiler $bladeCompiler) {
$this->registerImpersonateDirectives($bladeCompiler);
});
}
```
**What also works:**
If it's really necessary to place the directive declaration inside the `register` method, do not wrap it with the `...afterResolving('blade.compiler',...` callback, that also worked with my tests.
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Évaluation
Cette issue n'a pas encore été évaluée.