(failure to?) sanitise fully capitalised suggestions
- 主要言語
- Haskell
- スター
- 744
- フォーク
- 22
- PR マージ指標
- 30日以内にマージされた PR はありません
説明
I often see a suggested filename where the text is ALL CAPS. When this occurs, would it be better to convert to Title Case?
The line [& titlecase](https://github.com/2mol/pboy/blob/a5ae553525d873b45e4bd829b8358705313d2b1e/src/Lib.hs#L145) seems to already be trying to do this, so is the behaviour a bug? Sorry if I have misunderstood the code, I don't read Haskell well.
Actually looking into Data.Text.Titlecase function, I don't think it would change an ALL CAPS string, so a fix may be to `Data.Text.toLower` the text before `titlecase`.
I would be happy to provide test cases where this happens, if you like.
コントリビューションガイド
このリポジトリのコントリビューションガイドは索引されていません
調査の方向性
The issue points to src/Lib.hs line 145 where titlecase is applied. Look at the Data.Text.Titlecase function to understand its behavior with all-caps input. The suggested fix is to call Data.Text.toLower before titlecase. Write a test to verify the change works on all-caps filenames. Run the existing test suite to ensure no regressions.
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- haskell
- 領域
- cli
- issue の種類
- バグ
- 難易度
- 2/5
- 見積もり時間
- 1〜3時間
- 活発さ
- 停滞
- 明瞭さ
- 明確に書かれている
- 初心者へのやさしさ
- 70/100