2mol / 2mol/pboy

(failure to?) sanitise fully capitalised suggestions

Abierto Apto para principiantes
#53 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Haskell
Estrellas
744
Forks
22
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

I often see a suggested filename where the text is ALL CAPS. When this occurs, would it be better to convert to Title Case?

The line [& titlecase](https://github.com/2mol/pboy/blob/a5ae553525d873b45e4bd829b8358705313d2b1e/src/Lib.hs#L145) seems to already be trying to do this, so is the behaviour a bug? Sorry if I have misunderstood the code, I don't read Haskell well.

Actually looking into Data.Text.Titlecase function, I don't think it would change an ALL CAPS string, so a fix may be to `Data.Text.toLower` the text before `titlecase`.

I would be happy to provide test cases where this happens, if you like.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Línea de trabajo

The issue points to src/Lib.hs line 145 where titlecase is applied. Look at the Data.Text.Titlecase function to understand its behavior with all-caps input. The suggested fix is to call Data.Text.toLower before titlecase. Write a test to verify the change works on all-caps filenames. Run the existing test suite to ensure no regressions.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
haskell
Área
cli
Tipo de issue
Error
Dificultad
2/5
Tiempo estimado
1-3 horas
Estado de actividad
Estancado
Claridad
Bien especificado
Aptitud para principiantes
70/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.