(failure to?) sanitise fully capitalised suggestions
- Dominant language
- Haskell
- Stars
- 744
- Forks
- 22
- PR merge metrics
- No merged PRs in 30d
Description
I often see a suggested filename where the text is ALL CAPS. When this occurs, would it be better to convert to Title Case?
The line [& titlecase](https://github.com/2mol/pboy/blob/a5ae553525d873b45e4bd829b8358705313d2b1e/src/Lib.hs#L145) seems to already be trying to do this, so is the behaviour a bug? Sorry if I have misunderstood the code, I don't read Haskell well.
Actually looking into Data.Text.Titlecase function, I don't think it would change an ALL CAPS string, so a fix may be to `Data.Text.toLower` the text before `titlecase`.
I would be happy to provide test cases where this happens, if you like.
Contributor guide
No contributing guide indexed for this repository
Research direction
The issue points to src/Lib.hs line 145 where titlecase is applied. Look at the Data.Text.Titlecase function to understand its behavior with all-caps input. The suggested fix is to call Data.Text.toLower before titlecase. Write a test to verify the change works on all-caps filenames. Run the existing test suite to ensure no regressions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- haskell
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 70/100