(failure to?) sanitise fully capitalised suggestions
- 主要语言
- Haskell
- 星标
- 744
- 派生
- 22
- PR 合并指标
- 30 天内没有已合并 PR
描述
I often see a suggested filename where the text is ALL CAPS. When this occurs, would it be better to convert to Title Case?
The line [& titlecase](https://github.com/2mol/pboy/blob/a5ae553525d873b45e4bd829b8358705313d2b1e/src/Lib.hs#L145) seems to already be trying to do this, so is the behaviour a bug? Sorry if I have misunderstood the code, I don't read Haskell well.
Actually looking into Data.Text.Titlecase function, I don't think it would change an ALL CAPS string, so a fix may be to `Data.Text.toLower` the text before `titlecase`.
I would be happy to provide test cases where this happens, if you like.
贡献指南
这个仓库没有索引到贡献指南
调研方向
The issue points to src/Lib.hs line 145 where titlecase is applied. Look at the Data.Text.Titlecase function to understand its behavior with all-caps input. The suggested fix is to call Data.Text.toLower before titlecase. Write a test to verify the change works on all-caps filenames. Run the existing test suite to ensure no regressions.
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- haskell
- 领域
- cli
- Issue 类型
- 缺陷
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 活跃度
- 停滞
- 描述清晰度
- 描述清楚
- 新手友好度
- 70/100