0xMiden / 0xMiden/rust-sdk

Rename `mint` CLI command

Đang mở
#1,599 4 bình luận 0 reaction 0 người được giao Xem trên GitHub
cli
Ngôn ngữ chính
Rust
Star
78
Fork
129
Merge trung bình
4 ngày 14 giờ
Pull request đã merge (30 ngày)
52

Mô tả

### Background

A new `mint` command will be implemented in the `miden-faucet` repository and exposed through `midenup`, allowing users to run `miden mint` (which maps to the underlying `miden-faucet mint` command). See this issue here for more information: https://github.com/0xMiden/miden-faucet/issues/192

However, the `miden-client` repository already contains a `mint` command used to mint assets from a locally tracked (and created) faucet account.

### Problem

For users interacting with components like `miden-client` and `miden-faucet` through `midenup` (which most users will do in the future), having two commands with identical names creates confusion:
1. The distinction between their functionalities is not immediately apparent
2. This presents a potential future naming collision

### Proposed Solution

Rename the `miden-client mint` command to something more specific, such as `mint-local` (which was already proposed by @igamigo in a recent PR on the `miden-client` repository), to clearly differentiate it from the `miden-faucet mint` command.

This would make it immediately clear that:
- `miden mint` => mints from the live faucet
- `miden mint-local`=> mints from a locally tracked faucet account

Any thoughts on this are highly appreciated!

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.